Skip to content

Conversation

@pieterbos
Copy link
Collaborator

@pieterbos pieterbos commented May 13, 2020

Very much draft/experimental OpenAPI model generator. Few problems still:

  • multiple inheritance ONLY takes into account the first ancestor. Needs fixing
  • do we need oneOf references to indicate which subclasses are to be used, or is it ok as is?
  • do we need explicity type property mappings?

TODO:

  • fix the maps in ResourceDescription. It's now excluded from the RM, which is fine, but a reference to a single base file would be even better, so it needs to be correct for the AOM anyway.

@pieterbos pieterbos marked this pull request as draft May 13, 2020 20:17
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Attention: Patch coverage is 85.31073% with 104 lines in your changes missing coverage. Please review.

Project coverage is 71.01%. Comparing base (1604340) to head (3f570e1).
Report is 406 commits behind head on master.

Files with missing lines Patch % Lines
.../com/nedap/archie/openapi/OpenAPIModelCreator.java 87.28% 26 Missing and 11 partials ⚠️
...archie/openapi/ModelInfoLookupToPBmmConverter.java 88.27% 7 Missing and 10 partials ⚠️
.../java/com/nedap/archie/json/JSONSchemaCreator.java 85.89% 7 Missing and 4 partials ⚠️
...ava/com/nedap/archie/json/JsonSchemaValidator.java 60.71% 11 Missing ⚠️
...nedap/archie/rminfo/ReflectionModelInfoLookup.java 60.00% 5 Missing and 5 partials ⚠️
...a/com/nedap/archie/rminfo/ArchieAOMInfoLookup.java 50.00% 7 Missing and 2 partials ⚠️
...main/java/com/nedap/archie/json/JsonSchemaUri.java 78.57% 0 Missing and 3 partials ⚠️
.../bmm/v2/validation/converters/BmmModelCreator.java 86.66% 0 Missing and 2 partials ⚠️
...va/com/nedap/archie/openapi/RedefinedProperty.java 83.33% 2 Missing ⚠️
...com/nedap/archie/json/flat/AttributeReference.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
+ Coverage     70.53%   71.01%   +0.48%     
- Complexity     6489     6693     +204     
============================================
  Files           640      645       +5     
  Lines         21662    22301     +639     
  Branches       3485     3586     +101     
============================================
+ Hits          15279    15838     +559     
- Misses         4755     4798      +43     
- Partials       1628     1665      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pieterbos pieterbos force-pushed the openapi_model_generator branch from fe95578 to a35ce93 Compare May 15, 2020 13:32
@pieterbos pieterbos marked this pull request as ready for review May 31, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants