Skip to content

Conversation

@joostholslag
Copy link

@joostholslag joostholslag commented Feb 16, 2025

Draft (to keep up to date on progresse)

  • [WIP] ADL++

  • [WIP] ADL++


ADL 2.4 support in Archie

* [WIP] ADL++

* [WIP] ADL++

---------

Co-authored-by: Jelte Zeilstra <jelte.zeilstra@nedap.com>
@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.98%. Comparing base (ce89c2a) to head (4bc0e11).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #660   +/-   ##
=========================================
  Coverage     71.98%   71.98%           
- Complexity     7096     7097    +1     
=========================================
  Files           672      672           
  Lines         23154    23154           
  Branches       3755     3755           
=========================================
+ Hits          16667    16668    +1     
  Misses         4746     4746           
+ Partials       1741     1740    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@borutjures
Copy link

@joostholslag What is the purpose of this PR? It includes the changes from #659 which were merged 2 days ago.

@joostholslag
Copy link
Author

That pr was merged into a branch that this pr now merges into main. I assume more changes will have to be done to have a single pr for adl2.4 changes to Archie.

@borutjures
Copy link

Thank you for pointing this out. I missed that #659 was merged into a branch. Can't wait to land these changes into main branch.

@joostholslag
Copy link
Author

@MattijsK would you be willing to list the other required changes in the PR description?

@joostholslag
Copy link
Author

This file needs updating too https://github.com/openEHR/archie/blob/master/base/src/main/java/com/nedap/archie/definitions/AdlCodeDefinitions.java

not sure it’s covered by the todo in the pr text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants