Skip to content

Conversation

@J3173
Copy link
Collaborator

@J3173 J3173 commented Dec 16, 2025

Create AttributeAccessor utility class to provide access to the attributes of AOM and RM objects.

This new class is fully documented and tested. It handles all logic and exception handling of reflections internally and clearly defines which exceptions are thrown when.

This new class replaces the RMObjectAttributes class and the set, addElementToList and addElementToListOrSetSingleValues methods of RMObjectCreator. These are now deprecated.

Although the AttributeAccessor is not directly related to the AOM, it is defined in the AOM subproject as the ModelInfoLookup interface (which is needed by AttributeAccessor) is defined in that subproject. This allows the AttributeAccessor to be used without depending on the path-queries or tools subproject.

@J3173 J3173 self-assigned this Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 85.94595% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.18%. Comparing base (cc04a76) to head (af67dcb).

Files with missing lines Patch % Lines
.../main/java/com/nedap/archie/query/RMPathQuery.java 67.74% 15 Missing and 5 partials ⚠️
...nedap/archie/rules/evaluation/AssertionsFixer.java 68.75% 4 Missing and 1 partial ⚠️
...ain/java/com/nedap/archie/aom/CAttributeTuple.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #732      +/-   ##
============================================
+ Coverage     72.03%   72.18%   +0.15%     
- Complexity     7151     7185      +34     
============================================
  Files           677      678       +1     
  Lines         23277    23343      +66     
  Branches       3764     3778      +14     
============================================
+ Hits          16767    16851      +84     
+ Misses         4769     4753      -16     
+ Partials       1741     1739       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants