Send email even if there was an exception in Preparsing
#557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 5, 2023
tsujigiri
changed the title
Preparsing
Collaborator
Author
|
Should we set it to not retry on error? The outcome wouldn't be different the next time around (unless we fix it in the meantime) and with this change, we would send the email on every try... 😬 |
Member
|
Yeah, I think that's a fair point! I think we did do a retry as the task would sometimes unmotivatedly crash in the past. But let's assume that's solved? 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is an exception in
Preparse, the user never gets notified. This at least lets them know that something went wrong. I'm still looking for the cause of this specific error.