Changes to view-comment.tcl and .adp to correct misbehavior while switching between revisions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter revision_id is overwritten by the revision_id of the first revision in line number 93 when revisions are retrieved from the database. Solution: introduction of new variale keeping the original (current) revision id
…of other commit to view-comment.tcl
Contributor
|
Sorry for taking long to answer... I see what problem you are trying to solve. Your patch solves it partly, I guess revisions are mismanaged on this view of comments. Try to un-approve all revisions then, approve the first one; it is marked as live correctly in the list but when I want to see again this comment, always the last revision is shown here; I guess the live revision should be shown. Ill try to fix this and commit it to CVS ( since cvs is still the official tool for managing the code ). I'll let the pull request open though just as a reminder. |
vguerra
force-pushed
the
master
branch
2 times, most recently
from
bb6ecfa to
23d5cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.