-
Notifications
You must be signed in to change notification settings - Fork 34
TASK-7645 - Integrated Clinical Preprocessing, Variant Assessment, and Reporting #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Task linked: TASK-7645 Implement Variant Review and Summaries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the clinical variant interpretation models and creators by introducing new filtering capabilities, expanding the clinical variant data model with additional fields, and refactoring the status workflow. The changes support integrated clinical preprocessing, variant assessment, and reporting capabilities.
Key Changes:
- Introduced
ClinicalVariantFilterclass to capture query parameters and version information for clinical variant filtering - Enhanced
ClinicalVariantmodel with new fields includingmodesOfInheritance,images,version, and replaced deprecatedfiltersMap with structuredfilterobject - Updated
MiniPubmedmodel to renamenamefield totitleand addauthorsfield with backward compatibility through deprecated methods - Expanded
ClinicalVariant.Statusenum with new workflow states (UNDER_CONSIDERATION, CANDIDATE, VALIDATION_REQUESTED, VALIDATED) replacing REVIEW_REQUESTED
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ClinicalVariantFilter.java | New class added to encapsulate variant filter queries and version tracking for OpenCGA and CellBase |
| ClinicalVariant.java | Updated constructor signatures, added new fields (modesOfInheritance, images, version), deprecated old filter field, and modified Status enum values |
| MiniPubmed.java | Renamed name field to title with backward compatibility, added authors field, and updated constructors |
| ClinicalEvidenceReview.java | Added tags and score fields to support enhanced evidence review capabilities |
| TieringClinicalVariantCreator.java | Updated ClinicalVariant constructor calls to use new signature with ClinicalVariantFilter and additional parameters |
| TeamClinicalVariantCreator.java | Updated ClinicalVariant constructor calls to match new API signature |
| DefaultClinicalVariantCreator.java | Updated ClinicalVariant constructor calls to match new API signature |
| ClinicalVariantCreator.java | Updated ClinicalVariant constructor calls in createSecondaryFindings method |
Comments suppressed due to low confidence (1)
biodata-models/src/main/java/org/opencb/biodata/models/clinical/interpretation/ClinicalVariant.java:64
- The enum value 'REVIEW_REQUESTED' has been removed and replaced with new values including 'UNDER_CONSIDERATION', 'CANDIDATE', 'VALIDATION_REQUESTED', and 'VALIDATED'. This is a breaking change that will affect any code checking for the REVIEW_REQUESTED status. Ensure that all code using this enum value has been updated to handle the new workflow states appropriately.
public enum Status {
NOT_REVIEWED,
UNDER_CONSIDERATION,
CANDIDATE,
REVIEWED,
VALIDATION_REQUESTED,
VALIDATED,
DISCARDED,
REPORTED,
ARTIFACT
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
biodata-models/src/main/java/org/opencb/biodata/models/clinical/interpretation/MiniPubmed.java
Outdated
Show resolved
Hide resolved
...-models/src/main/java/org/opencb/biodata/models/clinical/interpretation/ClinicalVariant.java
Show resolved
Hide resolved
...-models/src/main/java/org/opencb/biodata/models/clinical/interpretation/ClinicalVariant.java
Outdated
Show resolved
Hide resolved
...-models/src/main/java/org/opencb/biodata/models/clinical/interpretation/ClinicalVariant.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.