Draft: Dominance Tree #133
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I am currently working on implementing a dominance tree data structure that closely mirrors with the one defined in LLVM: https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Support/GenericDomTree.h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently have an untested function
getDominanceInfo. I'm starting to suspect that the Cooper-Harvey-Kennedy algorithm I based this off of might not be the best way forward here because MLIR doesn't explicitly store block predecessors and successors.There are many issues I have with my current implementation.
BlockPtrs that doesn't even have any meaning beyond the internal mapping I create (and then discard), I should create a DomTree data structure to return instead (this is what LLVM and MLIR do).visitPostOrderfunction is an absolute abomination - a consequence to how new I am to Lean.This is my progress so far but I think I'm going to end up rewriting most if it soon.