refactor(p2p): JSON encoding to use protobuf instead #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybeast
reviewed
Feb 24, 2021
Contributor
maybeast
left a comment
maybeast
left a comment
There was a problem hiding this comment.
As this is a breaking change can we bump the minCompatibleVersion in the package.json so that newer nodes will reject p2p connections with older versions.
Author
|
So should I bump |
Contributor
Good point. We'll need to bump We can leave it out of this PR - sorry for the confusion. I'll do some manual testing on this branch in the coming days. Think we can get this in. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing opendexnetwork/opendex.network#34.
Changes:
SessionInitp2p packet fields needed for signing to be encoded via the same protobuf's scheme of the entire packet, instead of JSON. Using a subset of the fields isn't a problem with protobuf - the used fields will be encoded while the remaining ones won't exist on the binary representation.BREAKING CHANGE: JSON encoding to use protobuf instead