Drop Python 3.8 and Add Python 3.12 Support #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abubakarkhawaja
force-pushed
the
abubakarkhawaja/python-3.12-upgrade
branch
from
1531bf5 to
efc46e3
Compare
ttqureshi
suggested changes
May 14, 2025
ttqureshi
approved these changes
May 14, 2025
Contributor
Author
|
Hi, @feanil - tagging you to run the workflows and merge this Python 3.12 upgrade PR. Thanks! |
feanil
requested changes
Jun 2, 2025
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Small change to the coverage section and then this will be good to merge and release.
feanil
approved these changes
Jun 4, 2025
Contributor
|
Hmm, for some reason the CI workflow did not run yet. need that run and passing before we can merge this. |
There were spacing related syntax errors that needed to be resolved.
feanil
force-pushed
the
abubakarkhawaja/python-3.12-upgrade
branch
3 times, most recently
from
97441f3 to
d494e15
Compare
The tox env can't run if the underlying python version doesn't exist.
feanil
force-pushed
the
abubakarkhawaja/python-3.12-upgrade
branch
from
d494e15 to
8052ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Removed python 3.8 instances and added support for python 3.11 and 3.12.
Also removed
sixpackage, as we are no longer supporting older python versions.Merge deadline: List merge deadline (if any)
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Ran make commands for testing:
make test-allmake validateReviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.