Drop usage of ubuntu-20.04 #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
irtazaakram
commented
Feb 17, 2025
irtazaakram
commented
- related to Drop usage of ubuntu-20.04 public-engineering#313
Contributor
MoisesGSalas
left a comment
MoisesGSalas
left a comment
There was a problem hiding this comment.
This also disables testing for Ubuntu 22.04 doesn't it? We still are going to need to test both 22.04 and 24.04.
feanil
reviewed
Feb 19, 2025
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
@irtazaakram I agree with @MoisesGSalas , this is a special case where we don't want to go to just testing on latest, for codejail, we want to be explicitly testing on specific ubuntu versions, we can drop 20.04 from the list but we should keep 22.04 and 24.04 explicitly.
irtazaakram
force-pushed
the
ubuntu-latest
branch
from
1f220b4 to
cfb85a6
Compare
Member
Author
|
Hi @feanil @MoisesGSalas Thank you for the feedback! I've updated the code to ensure we explicitly test on both Ubuntu 22.04 and 24.04. |
MoisesGSalas
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.