Skip to content

Conversation

@Henrrypg
Copy link
Contributor

@Henrrypg Henrrypg commented Dec 23, 2025

This PR makes it possible to have configurations such as the model or api_key in the profile (not recomended, but it makes onboarding very easy).

During the refactor, the name of "config" in the LLMProcessor was changed to "provider" to better reflect the use that is getting. Also "config" is a very loaded word already.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 23, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 23, 2025

Thanks for the pull request, @Henrrypg!

This repository is currently maintained by @felipemontoya.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Dec 23, 2025
@felipemontoya felipemontoya force-pushed the hpg/override_config branch 3 times, most recently from 029c51b to fb16e42 Compare December 24, 2025 01:41
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.38%. Comparing base (c4a03d7) to head (0b1611a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   90.09%   90.38%   +0.29%     
==========================================
  Files          46       46              
  Lines        4129     4182      +53     
  Branches      266      267       +1     
==========================================
+ Hits         3720     3780      +60     
+ Misses        320      314       -6     
+ Partials       89       88       -1     
Flag Coverage Δ
unittests 90.38% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felipemontoya felipemontoya marked this pull request as ready for review December 24, 2025 01:52
@felipemontoya felipemontoya self-requested a review December 24, 2025 02:29
@felipemontoya felipemontoya changed the title feat allow model and key overrides in the profile Dec 24, 2025
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrry. I took your code and refactored a bit more.

@felipemontoya felipemontoya merged commit 70959a6 into openedx:main Dec 24, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants