Messages: handle app notifications #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to handle app notifications for messages. It updates the @openforis/arena-core dependency from version 1.0.69 to 1.0.75 to gain access to new message notification capabilities, implements a new service method to filter messages for push notifications targeted at specific users, and exposes two new API endpoints for retrieving these notifications.
- Updates arena-core dependency to access MessageNotificationType and related utilities
- Adds getNotifiedToUser service method to filter messages by notification type and user targeting
- Implements new authentication middleware for logged-in user validation and refactors error handling
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates @openforis/arena-core dependency to version 1.0.75 |
| yarn.lock | Updates lockfile with new arena-core version and checksum |
| src/service/message/index.ts | Adds getNotifiedToUser method to filter messages by push notification type and user targeting |
| src/api/middleware/auth.ts | Refactors unauthorized error handling and adds requireLoggedInUser middleware |
| src/api/message/read.ts | Adds two new endpoints for retrieving notified messages and their count |
| src/api/endpoint/message.ts | Defines two new endpoint paths for notified messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.