correctly generate version export in main library #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since npm@3, node_modules directory might be flattened out. Since version is supposed to be the version of the "to" library, getVersion should explicitly provide the package.json of the project, instead of relying on handy to determine the correct one. This fixes helpers/handlebars-helpers#199
|
I've hit the same problem... unfortunately this package seems to be abandoned. |
|
Note: this PR has a bug itself, it tries to feed the path to I submitted another PR which fixes this: #4 |
Author
|
Oh, you are right … No need for this to stay open, then. Thanks for the information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since npm@3, node_modules directory might be flattened out. Since version is supposed to be the version of the "to" library, getVersion should explicitly provide the package.json of the project, instead of relying on handy to determine the correct one.
This fixes helpers/handlebars-helpers#199