-
-
Notifications
You must be signed in to change notification settings - Fork 211
refactor: Deprecate array formats and default to dataframe #1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1372 +/- ##
===========================================
- Coverage 84.33% 84.18% -0.16%
===========================================
Files 38 38
Lines 5325 5230 -95
===========================================
- Hits 4491 4403 -88
+ Misses 834 827 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
53e3cec to
6296f37
Compare
SubhadityaMukherjee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay looks good to me now. Merge conflicts were fixed, target_names was renamed back to target since I could not find a reason to change it everywhere.
|
I am not confident in trying to merge it to develop until the tests are up and running again. |
I am not confident in trying to merge it to develop until the tests are up and running again.
LennartPurucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did one full pass, LGTM, now looking into tests
PGijsbers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much fine to merge
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
…to refactor-default-dataframe
PGijsbers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
WIP