Skip to content

Conversation

@eddiebergman
Copy link
Collaborator

WIP

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 80.84291% with 50 lines in your changes missing coverage. Please review.

Project coverage is 84.18%. Comparing base (00d1766) to head (22b6b52).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
openml/study/functions.py 17.39% 19 Missing ⚠️
openml/datasets/dataset.py 78.94% 8 Missing ⚠️
openml/evaluations/functions.py 81.08% 7 Missing ⚠️
openml/runs/functions.py 78.12% 7 Missing ⚠️
openml/utils.py 80.00% 3 Missing ⚠️
openml/extensions/sklearn/extension.py 77.77% 2 Missing ⚠️
openml/setups/functions.py 94.28% 2 Missing ⚠️
openml/datasets/functions.py 95.23% 1 Missing ⚠️
openml/tasks/functions.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1372      +/-   ##
===========================================
- Coverage    84.33%   84.18%   -0.16%     
===========================================
  Files           38       38              
  Lines         5325     5230      -95     
===========================================
- Hits          4491     4403      -88     
+ Misses         834      827       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eddiebergman eddiebergman force-pushed the refactor-default-dataframe branch from 53e3cec to 6296f37 Compare October 17, 2024 15:10
Copy link
Contributor

@SubhadityaMukherjee SubhadityaMukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay looks good to me now. Merge conflicts were fixed, target_names was renamed back to target since I could not find a reason to change it everywhere.

@SubhadityaMukherjee
Copy link
Contributor

I am not confident in trying to merge it to develop until the tests are up and running again.

@SubhadityaMukherjee SubhadityaMukherjee dismissed their stale review April 1, 2025 13:42

I am not confident in trying to merge it to develop until the tests are up and running again.

Copy link
Contributor

@LennartPurucker LennartPurucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did one full pass, LGTM, now looking into tests

Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much fine to merge

LennartPurucker and others added 6 commits June 17, 2025 15:03
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LennartPurucker LennartPurucker merged commit d36593d into develop Jun 17, 2025
0 of 13 checks passed
@LennartPurucker LennartPurucker deleted the refactor-default-dataframe branch June 17, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants