Skip to content

MAP-18: line memory usage #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
stmitt wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

MAP-18: line memory usage #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa0637d
combine line vertex attributes
stmitt Mar 3, 2025
1998e48
move packLineStyleMetadata into helper
stmitt Mar 3, 2025
b2eb931
fix jvm build
stmitt Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions ios/graphics/Model/Line/LineVertex.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,24 +30,12 @@ public struct LineVertex: Equatable {
vertexDescriptor.attributes[1].offset = offset
offset += 3 * MemoryLayout<Float>.stride

// Vertex Index
// Metadata
vertexDescriptor.attributes[2].bufferIndex = bufferIndex
vertexDescriptor.attributes[2].format = .float
vertexDescriptor.attributes[2].offset = offset
offset += MemoryLayout<Float>.stride

// Length Prefix
vertexDescriptor.attributes[3].bufferIndex = bufferIndex
vertexDescriptor.attributes[3].format = .float
vertexDescriptor.attributes[3].offset = offset
offset += MemoryLayout<Float>.stride

// Line Style Info
vertexDescriptor.attributes[4].bufferIndex = bufferIndex
vertexDescriptor.attributes[4].format = .float
vertexDescriptor.attributes[4].offset = offset
offset += MemoryLayout<Float>.stride

vertexDescriptor.layouts[0].stride = offset
return vertexDescriptor
}()
Expand All @@ -69,24 +57,12 @@ public struct LineVertex: Equatable {
vertexDescriptor.attributes[1].offset = offset
offset += 2 * MemoryLayout<Float>.stride

// Vertex Index
// Metadata
vertexDescriptor.attributes[2].bufferIndex = bufferIndex
vertexDescriptor.attributes[2].format = .float
vertexDescriptor.attributes[2].offset = offset
offset += MemoryLayout<Float>.stride

// Length Prefix
vertexDescriptor.attributes[3].bufferIndex = bufferIndex
vertexDescriptor.attributes[3].format = .float
vertexDescriptor.attributes[3].offset = offset
offset += MemoryLayout<Float>.stride

// Line Style Info
vertexDescriptor.attributes[4].bufferIndex = bufferIndex
vertexDescriptor.attributes[4].format = .float
vertexDescriptor.attributes[4].offset = offset
offset += MemoryLayout<Float>.stride

vertexDescriptor.layouts[0].stride = offset
return vertexDescriptor
}()
Expand Down
Loading
Loading