Skip to content

Feature/expression tests #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
stmitt wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Feature/expression tests #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92dab96
Add MapLibre expression test framework with comprehensive test suite
stmitt Aug 1, 2025
2a2d283
fixes segmentation fault
stmitt Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 4 additions & 2 deletions shared/src/map/layers/tiled/vector/Tiled2dMapVectorStyleParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,8 @@ std::shared_ptr<Value> Tiled2dMapVectorStyleParser::parseValue(nlohmann::json js

std::map<std::set<ValueVariant>, std::shared_ptr<Value>> mapping;

auto const countElements = json.size() - 3;
for (int i = 0; i != countElements; i += 2) {
auto const countElements = json.size() >= 3 ? json.size() - 3 : 0;
for (int i = 0; i < countElements; i += 2) {
std::set<ValueVariant> values;
if (json[2 + i].is_array()) {
for(auto const value: json[2 + i]) {
Expand Down Expand Up @@ -521,6 +521,8 @@ ValueVariant Tiled2dMapVectorStyleParser::getVariant(const nlohmann::json &json)
return json.get<int64_t>();
} else if (json.is_boolean()) {
return json.get<bool>();
} else if (json.is_array() && json.empty()) {
return std::vector<float>();
} else if (json.is_array() && json[0].is_number()) {
auto floatVector = std::vector<float>();
floatVector.reserve(json.size());
Expand Down
4 changes: 2 additions & 2 deletions shared/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ add_executable(tests
"TestTileSource.cpp"
"TestGeometryHandler.cpp"
"TestStyleParser.cpp"
"TestValueEvaluate.cpp"
"TestVectorSet.cpp"
"TestVectorSet.cpp"
"TestStyleParser.cpp"
"TestInternedString.cpp"
"TestExpressions.cpp"
"helper/TestData.cpp"
"helper/TestLocalDataProvider.h"
)
Expand Down
Loading
Loading