Skip to content

Conversation

@LuckyMD
Copy link
Collaborator

@LuckyMD LuckyMD commented Jul 18, 2022

This adds an scanvi+scarches+xgboost method for the label projection task.

Submission type

  • This submission adds a new dataset
  • This submission adds a new method
  • This submission adds a new metric
  • This submission adds a new task
  • This submission adds a new Docker image
  • This submission fixes a bug (link to related issue: )
  • This submission adds a new feature not listed above

Testing

  • This submission was written on a forked copy of SingleCellOpenProblems
  • GitHub Actions "Run Benchmark" tests are passing on this base branch of this pull request (include link to passed test: )
  • If this pull request is not ready for review (including passing the "Run Benchmark" tests), I will open this PR as a draft (click on the down arrow next to the "Create Pull Request" button)

Submission guidelines

  • This submission follows the guidelines in our Contributing document
  • I have checked to ensure there aren't other open Pull Requests for the same update/change

PR review checklist

This PR will be evaluated on the basis of the following checks:

  • The task addresses a valid open problem in single-cell analysis
  • The latest version of master is merged and tested
  • The methods/metrics are imported to __init__.py and were tested in the pipeline
  • Method and metric decorators are annotated with paper title, year, author, code version, and date
  • The README gives an outline of the methods, metrics and datasets in the folder
  • The README provides a satisfactory task explanation (for new tasks)
  • The sample test data is appropriate to test implementation of all methods and metrics (for new tasks)

@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Jul 18, 2022

Not sure why i don't see the CI tests on my own fork... any idea @scottgigante-immunai ?

@scottgigante-immunai
Copy link
Collaborator

Not sure why they don't show up on your local fork PR, but regardless the place to look is https://github.com/LuckyMD/SingleCellOpenProblems/actions

@scottgigante-immunai scottgigante-immunai marked this pull request as draft July 18, 2022 19:35
@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Jul 19, 2022

Got it, thanks! I don't seem to have an nf-tower access token. You recently set this up, no? @scottgigante-immunai

@scottgigante-immunai
Copy link
Collaborator

Yep, you will need to create it. Per CONTRIBUTING.md:

Create repository secrets (not environment secrets) at https://github.com/USERNAME/openproblems/settings/secrets

AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY are included in your AWS login details. If you do not have these, please contact us at singlecellopenproblems@protonmail.com.
TOWER_ACCESS_KEY: log in with GitHub to https://tower.nf/ and create a token at https://tower.nf/tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants