-
Notifications
You must be signed in to change notification settings - Fork 199
OCPBUGS-62790: Restore agent MASTER_MEMORY default to 16GiB #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
openshift/installer#10133 (4.21), openshift/installer#10140 (4.20), and openshift/installer#10153 (4.19) have all merged. |
Previously whenever an agent scenario was specified, it overrode the vCPU count, disk size, and memory size from the config file. Change this so that the agent scenario values are used as a default, but the configuration can override with the usual environment variables like MASTER_MEMORY.
The default MASTER_MEMORY was changed in some agent scenarios in order to work around a problem in OKD where FCOS would use only 20% of RAM for the ephemeral storage instead of 50%. Other scenarios were later changed to match when tests started failing in 4.19 due to OCPBUGS-62790. Return the defaults to the minimum values validated by assisted-service in ABI, so that any future regressions like OCPBUGS-62790 are caught immediately.
77d2124 to
3678ebd
Compare
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Tests appear to be still failing with "no space left on disk" when pulling images, even though the fix has worked as intended and created a separate tmpfs for the ostree (and even though there is still 815MiB free): This implies that even without the coreos layering change, we would be exceeding the limit for 16GiB servers now. In my local testing 16GiB servers worked OK, so I am not sure what is different here. |
The default MASTER_MEMORY was changed in some agent scenarios in order
to work around a problem in OKD where FCOS would use only 20% of RAM for
the ephemeral storage instead of 50%. Other scenarios were later changed
to match when tests started failing in 4.19 due to OCPBUGS-62790.
Return the defaults to the minimum values validated by assisted-service
in ABI, so that any future regressions like OCPBUGS-62790 are caught
immediately.
This depends on openshift/installer#10133, including backports to 4.20 and 4.19.