Skip to content

Conversation

@hongkailiu
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 23, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request references Jira Issue OCPBUGS-53062, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member Author

launch 4.19,openshift/cluster-version-operator#1180 gcp

Then

$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.19.0-0-2025-04-23-203441-test-ci-ln-7hshwg2-latest   True        False         24m     Cluster version is 4.19.0-0-2025-04-23-203441-test-ci-ln-7hshwg2-latest

$ oc describe pod -n openshift-cluster-version cluster-version-operator-867f99cf4b-g4fzb | grep Port:
    Port:          9099/TCP
...

$ oc get pod -n openshift-cluster-version cluster-version-operator-867f99cf4b-g4fzb -o yaml | yq -y '.spec.containers[0].ports'
- containerPort: 9099
  hostPort: 9099
  name: http
  protocol: TCP

@hongkailiu
Copy link
Member Author

/retest

@hongkailiu
Copy link
Member Author

/test e2e-aws-ovn-techpreview

1 similar comment
@hongkailiu
Copy link
Member Author

/test e2e-aws-ovn-techpreview

@hongkailiu
Copy link
Member Author

error: unable to read image registry.build11.ci.openshift.org/ci-op-pbqpqp5d/stable@sha256:97a44512f5f0218b8e78cdd7f2974cdfb58352b898ef078b941188ec5050b7d1: unable to retrieve source image registry.build11.ci.openshift.org/ci-op-pbqpqp5d/stable@sha256:97a44512f5f0218b8e78cdd7f2974cdfb58352b898ef078b941188ec5050b7d1 manifest #1 from manifest list: received unexpected HTTP status: 504 Gateway Time-out

Seems like a CI infra issue.

/test e2e-aws-ovn-techpreview

Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question

@petr-muller
Copy link
Member

/hold

Holding to allow addressing the question, if needed

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2025
@hongkailiu
Copy link
Member Author

/test e2e-aws-ovn-techpreview

@hongkailiu
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request references Jira Issue OCPBUGS-53062, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @dis016

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from dis016 April 24, 2025 14:28
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025
@hongkailiu hongkailiu requested review from petr-muller and wking April 25, 2025 13:16
@hongkailiu
Copy link
Member Author

/retest

1 similar comment
@hongkailiu
Copy link
Member Author

/retest

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn add8a5f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hongkailiu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2025
@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 2, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Jira Issue OCPBUGS-53062, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dis016
Copy link

dis016 commented May 2, 2025

Test Passed:

Step1:
Install a cluster with the fix.

launch 4.19,openshift/cluster-version-operator#1180 aws

Step2:
Check CVO Pod is configured on port 9099

 
dinesh@Dineshs-MacBook-Pro ~ % oc get clusterversion                                                                              
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.19.0-0-2025-05-02-064610-test-ci-ln-v6bx5qt-latest   True        False         111m    Cluster version is 4.19.0-0-2025-05-02-064610-test-ci-ln-v6bx5qt-latest
dinesh@Dineshs-MacBook-Pro ~ % 
dinesh@Dineshs-MacBook-Pro ~ % oc get pods -n openshift-cluster-version
NAME                                        READY   STATUS    RESTARTS   AGE
cluster-version-operator-5d5b448fb5-w6r6k   1/1     Running   0          137m
dinesh@Dineshs-MacBook-Pro ~ % oc describe pod -n openshift-cluster-version cluster-version-operator-5d5b448fb5-w6r6k | grep Port:
    Port:          9099/TCP
    Host Port:     9099/TCP
dinesh@Dineshs-MacBook-Pro ~ % oc get pod -n openshift-cluster-version  cluster-version-operator-5d5b448fb5-w6r6k -o json  | jq -r '.spec.containers[0].ports' 
[
  {
    "containerPort": 9099,
    "hostPort": 9099,
    "name": "metrics",
    "protocol": "TCP"
  }
]
dinesh@Dineshs-MacBook-Pro ~ %

@dis016
Copy link

dis016 commented May 2, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 2, 2025
@hongkailiu
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 5, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request references Jira Issue OCPBUGS-53062, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @dis016

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5dbef31 into openshift:main May 5, 2025
14 of 15 checks passed
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: Jira Issue OCPBUGS-53062: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-53062 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.20.0-202505052112.p0.g5dbef31.assembly.stream.el9.
All builds following this will include this PR.

@aabughosh
Copy link

/cherry-pick release-4.19

@openshift-cherrypick-robot

@aabughosh: new pull request created: #1283

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants