Skip to content

AGENT-1309: Modify OVE storage requirements #10176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pawanpinjarkar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

AGENT-1309: Modify OVE storage requirements #10176

pawanpinjarkar wants to merge 1 commit into from
+23 −2

Conversation

@pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented Dec 18, 2025 •
edited
Loading

This PR introduces dynamic hardware validation requirements for agent-based installations, adjusting disk size requirements for NoRegistryClusterInstall.

Changes

  • Added configure-assisted-hw-requirements.sh script to dynamically configure hardware validator requirements
  • Modified assisted-service systemd unit to execute the configuration script before service start
  • Updated assisted-service environment template to use dynamic hardware requirements

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2025 •
edited by openshift-ci bot
Loading

@pawanpinjarkar: This pull request references AGENT-1309 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from andfasano and zaneb December 18, 2025 19:32
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2025 •
edited by openshift-ci bot
Loading

@pawanpinjarkar: This pull request references AGENT-1309 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces dynamic hardware validation requirements for agent-based installations, adjusting disk size requirements for NoRegistryClusterInstall.

Changes

  • Added configure-assisted-hw-requirements.sh script to dynamically configure hardware validator requirements
  • Modified assisted-service systemd unit to execute the configuration script before service start
  • Updated assisted-service environment template to use dynamic hardware requirements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar pawanpinjarkar force-pushed the modify-hw-storage-requirements-for-ove branch from a84fe0d to 6110103 Compare December 18, 2025 20:52
@pawanpinjarkar
Copy link
Contributor Author

pawanpinjarkar commented Dec 18, 2025

/hold for openshift-metal3/dev-scripts#1829

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2025
@pawanpinjarkar
Copy link
Contributor Author

pawanpinjarkar commented Dec 19, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2025
@pawanpinjarkar pawanpinjarkar force-pushed the modify-hw-storage-requirements-for-ove branch from 6110103 to 876f922 Compare December 19, 2025 19:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pawanpinjarkar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 876f922 link false /test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/e2e-agent-two-node-fencing-ipv4 876f922 link false /test e2e-agent-two-node-fencing-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

andfasano
andfasano reviewed Dec 23, 2025
View reviewed changes
data/data/agent/files/usr/local/bin/configure-assisted-hw-requirements.sh
ASSISTED_SERVICE_ENV_FILE="/usr/local/share/assisted-service/assisted-service.env"
DISK_SIZE_GB=100

# Increase disk size requirement for NoRegistryClusterInstall aka OVE
Copy link
Contributor

@andfasano andfasano Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Increase disk size requirement for NoRegistryClusterInstall aka OVE
# Increase disk size requirement for NoRegistryClusterInstall

data/data/agent/files/usr/local/bin/configure-assisted-hw-requirements.sh
DISK_SIZE_GB=220
fi

HW_VALIDATOR_REQUIREMENTS="[{\"version\":\"default\",\"master\":{\"cpu_cores\":4,\"ram_mib\":16384,\"disk_size_gb\":${DISK_SIZE_GB},\"installation_disk_speed_threshold_ms\":10,\"network_latency_threshold_ms\":100,\"packet_loss_percentage\":0},\"arbiter\":{\"cpu_cores\":2,\"ram_mib\":8192,\"disk_size_gb\":50,\"installation_disk_speed_threshold_ms\":10,\"network_latency_threshold_ms\":1000,\"packet_loss_percentage\":0},\"worker\":{\"cpu_cores\":2,\"ram_mib\":8192,\"disk_size_gb\":${DISK_SIZE_GB},\"installation_disk_speed_threshold_ms\":10,\"network_latency_threshold_ms\":1000,\"packet_loss_percentage\":10},\"sno\":{\"cpu_cores\":8,\"ram_mib\":16384,\"disk_size_gb\":${DISK_SIZE_GB},\"installation_disk_speed_threshold_ms\":10}}]"
Copy link
Contributor

@andfasano andfasano Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to manage the whole block? Ie, I was expecting a more narrowed change, something like:

sed 's/"disk_size_gb":[0-9]\+/"disk_size_gb":220/g'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaneb zaneb Awaiting requested review from zaneb

1 more reviewer

@andfasano andfasano andfasano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawanpinjarkar @openshift-ci-robot @andfasano