OCPBUGS-60568: Use BoundServceAccountTokenVolume dy default

[lance5890]

kind of post-cleanup of #1100 and openshift/kubernetes#714

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/operator/staticpod/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance5890]

/hold

[lance5890]

need to wait the openshift/cluster-version-operator#1225 to merge first

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[tchap]

/remove-lifecycle stale

[tchap]

Blocked by openshift/cluster-version-operator#1264 now.

[tchap]

/assign

[lance5890]

/assign

with the openshift/cluster-version-operator#1264 merged, this PR is not blocked now

[lance5890]

/unhold

[tchap]

/ok-to-test

[openshift-ci]

@lance5890: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tchap]

/test

[openshift-ci]

@tchap: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test e2e-aws-encryption

/test e2e-monitoring

/test unit

/test verify

/test verify-deps

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-library-go-master-unit

pull-ci-openshift-library-go-master-verify

pull-ci-openshift-library-go-master-verify-deps

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tchap]

We need to test this on a real component, please create a PR for cluster-kube-controller-manager-operator, for example, that uses this particular library-go PR so that we can see on CI that everything works. Thanks!

[tchap]

/hold

[lance5890]

We need to test this on a real component, please create a PR for cluster-kube-controller-manager-operator, for example, that uses this particular library-go PR so that we can see on CI that everything works. Thanks!

The cluster-kube-controller-manager-operator tests are all passed!

[bertinatto]

Just for my understanding, could you folks explain why these mounts aren't necessary anymore? IIUC from this comment, they were necessary for upgrades.

[lance5890]

Just for my understanding, could you folks explain why these mounts aren't necessary anymore? IIUC from this comment, they were necessary for upgrades.

yes, these were needed before, but within this PR openshift/cluster-version-operator#1264 merged, these mounts can be removed now, please see openshift/cluster-version-operator#1225

[lance5890]

/unhold

[openshift-ci-robot]

@lance5890: This pull request references Jira Issue OCPBUGS-60568, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

kind of post-cleanup of #1100 and openshift/kubernetes#714

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

/jira refresh

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-60568, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

The testing job looks OK BTW. When you inspect CI and check installer-7-ip-10-0-26-20.us-west-1.compute.internal, it's the first installer pod that uses the dynamic binding when upgrading.