Skip to content

SDCICD-1723: separate Framework-Level and Test-Level Log Analysis #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varunraokadaparthi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SDCICD-1723: separate Framework-Level and Test-Level Log Analysis #3074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/e2e/e2e.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package e2e
import (
"context"
"encoding/json"
"errors"
"fmt"
"log"
"os"
Expand Down Expand Up @@ -36,6 +37,9 @@ import (
// provisioner is used to deploy and manage clusters.
var provider spi.Provider

// ErrTestsFailed is returned when one or more tests fail.
var ErrTestsFailed = errors.New("tests failed, please inspect logs for more details")

// runLogAnalysis performs log analysis powered failure analysis if enabled
func runLogAnalysis(ctx context.Context, err error) {
log.Println("Running Log analysis")
Expand Down Expand Up @@ -218,7 +222,7 @@ func RunTests(ctx context.Context) int {
exitCode, err = runGinkgoTests()
if err != nil {
log.Printf("OSDE2E failed: %v", err)
if viper.GetBool(config.LogAnalysis.EnableAnalysis) {
if viper.GetBool(config.LogAnalysis.EnableAnalysis) && !errors.Is(err, ErrTestsFailed) {
runLogAnalysis(ctx, err)
}
}
Expand Down Expand Up @@ -350,7 +354,7 @@ func runGinkgoTests() (int, error) {

if !testsPassed || !upgradeTestsPassed {
viper.Set(config.Cluster.Passing, false)
return config.Failure, fmt.Errorf("tests failed, please inspect logs for more details")
return config.Failure, ErrTestsFailed
}

return config.Success, nil
Expand Down