Skip to content

Conversation

@kuiwang02
Copy link
Contributor

/cc @jianzhangbjz @Xia-Zhao-rh @bandrade

following #73547 , I find some PR miss the testdata file, but do not miss the bindata file, like openshift/operator-framework-operator-controller#603 (comment)

So, enhance it to run the checking if there is bindata file.

so, now if there is testdata file or updated bindata file, the bindata-check job will run.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2026

@kuiwang02: This pull request references OCPQE-31468 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/cc @jianzhangbjz @Xia-Zhao-rh @bandrade

following #73547 , I find some PR miss the testdata file, but do not miss the bindata file, like openshift/operator-framework-operator-controller#603 (comment)

So, enhance it to run the checking if there is bindata file.

so, now if there is testdata file or updated bindata file, the bindata-check job will run.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kuiwang02 kuiwang02 force-pushed the enhancebindatacheck branch from b86c155 to 821f9d1 Compare January 16, 2026 01:51
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@kuiwang02: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-operator-framework-olm-main-bindata-check openshift/operator-framework-olm presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-bindata-check openshift/operator-framework-operator-controller presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kuiwang02
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@kuiwang02: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kuiwang02
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-operator-framework-olm-main-bindata-check

@openshift-ci-robot
Copy link
Contributor

@kuiwang02: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kuiwang02
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-operator-framework-olm-main-bindata-check

@openshift-ci-robot
Copy link
Contributor

@kuiwang02: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kuiwang02
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@kuiwang02: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 19, 2026
@kuiwang02
Copy link
Contributor Author

/verified by @kuiwang02

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

@kuiwang02: This PR has been marked as verified by @kuiwang02.

Details

In response to this:

/verified by @kuiwang02

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, kuiwang02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@kuiwang02: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2747100 into openshift:master Jan 19, 2026
17 checks passed
@kuiwang02 kuiwang02 deleted the enhancebindatacheck branch January 19, 2026 01:36
SeanZhao-redhat pushed a commit to SeanZhao-redhat/openshift-release that referenced this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants