-
Notifications
You must be signed in to change notification settings - Fork 3
Switch to Caddy for managing certificates and fix env variables passing #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@hrishiballal would need to be tested online first before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates certificate management from cert-manager with nginx-ingress-controller to Caddy ingress controller, which provides automatic HTTPS certificate management. The PR also includes unrelated database configuration improvements.
- Removes cert-manager Issuer and Certificate resources
- Replaces nginx ingress with Caddy ingress controller
- Standardizes database connection strings to use environment variables
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/issuer-template.yaml | Removed - cert-manager issuer configuration no longer needed with Caddy |
| templates/certificate-wcard-template.yaml | Removed - Caddy handles wildcard certificates automatically |
| templates/certificate-root-template.yaml | Removed - Caddy handles root domain certificates automatically |
| templates/ingress-template.yaml | Migrated from nginx to Caddy ingress class, removed cert-manager annotations and TLS configuration |
| generate-from-templates.sh | Updated to only generate ingress configuration, removed cert-manager template processing |
| README.md | Updated installation instructions to use Caddy ingress controller instead of nginx + cert-manager |
| kustomize/passport/passport.yaml | Added POSTGRES_PORT environment variable and updated DATABASE_URL to use it; removed trailing whitespace |
| kustomize/passport/db-passport.yaml | Added POSTGRES_PORT environment variable |
| kustomize/blender/blender.yaml | Added POSTGRES_PORT environment variable and updated DATABASE_URL to use it; removed trailing whitespace |
| kustomize/blender/worker.yaml | Added POSTGRES_PORT environment variable and updated DATABASE_URL to use it; removed trailing whitespace |
| kustomize/blender/beat.yaml | Added POSTGRES_PORT environment variable and updated DATABASE_URL to use it; removed trailing whitespace |
| kustomize/blender/db-blender.yaml | Added POSTGRES_PORT environment variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.