-
Notifications
You must be signed in to change notification settings - Fork 6
Skeleton of blue sky simulation dataset implementation #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 73-integrate-bluesky-for-simulated-air-traffic-data
Are you sure you want to change the base?
Skeleton of blue sky simulation dataset implementation #77
Conversation
|
|
||
|
|
||
| @scenario_step("Generate BlueSky Simulation Air Traffic Data") | ||
| async def generate_bluesky_generated_air_traffic_data( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: use of word generated twice seems strange suggesting something like generate_bluesky_sim_airtraffic_data
| try: | ||
| traj_count = 3 | ||
| bs.init(mode='sim') | ||
| bs.traf.mcre(traj_count, actype="UAV") # Create n random UAVs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: we want to be able to generate both UAV and manned traffic
| @register_scenario("bluesky_sim_air_traffic_data") | ||
| async def test_bluesky_sim_air_traffic_data( | ||
| fb_client: FlightBlenderClient, | ||
| air_traffic_client: AirTrafficClient, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that a new client can be created called BlueSkyClient since I feel that Blue Sky is large enough and we will use it quite extensively in the future
|
Thank you so much for the effort! Looks great and I have made some minor comments |
Address comments and further build up the simulation
41dc71a to
969d1c0
Compare
Basic integration and skeleton for integrating BlueSky simulation dataset into our verification tester