Skip to content

Conversation

@seslash
Copy link

@seslash seslash commented Jan 7, 2026

Basic integration and skeleton for integrating BlueSky simulation dataset into our verification tester

@seslash seslash requested a review from hrishiballal January 7, 2026 18:57
@seslash seslash added the help wanted Extra attention is needed label Jan 7, 2026


@scenario_step("Generate BlueSky Simulation Air Traffic Data")
async def generate_bluesky_generated_air_traffic_data(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: use of word generated twice seems strange suggesting something like generate_bluesky_sim_airtraffic_data

try:
traj_count = 3
bs.init(mode='sim')
bs.traf.mcre(traj_count, actype="UAV") # Create n random UAVs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: we want to be able to generate both UAV and manned traffic

@register_scenario("bluesky_sim_air_traffic_data")
async def test_bluesky_sim_air_traffic_data(
fb_client: FlightBlenderClient,
air_traffic_client: AirTrafficClient,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that a new client can be created called BlueSkyClient since I feel that Blue Sky is large enough and we will use it quite extensively in the future

@hrishiballal
Copy link
Contributor

Thank you so much for the effort! Looks great and I have made some minor comments

Address comments and further build up the simulation
@seslash seslash force-pushed the bluesky_simulation_dev branch from 41dc71a to 969d1c0 Compare January 13, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants