relay: forward message if dns rewriting is impossible #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the DHCPV6_OPT_AUTH option is set in a DHCPv6 server response, we can't rewrite the DNS server within the response as it would result in a checksum mismatch. Instead of silently dropping the server response, forward the unmodified response instead. Signed-off-by: Mathias Kresin <dev@kresin.me>
systemcrash
reviewed
Oct 22, 2025
|
|
||
| if (rewrite_cnt == 0) { | ||
| if (odhcpd_get_interface_dns_addr(iface, &addr)) { | ||
| syslog(LOG_ERR, "Unable to get interface address"); |
Contributor
There was a problem hiding this comment.
Perhaps some more context in the error message. e.g.
syslog(LOG_ERR, "Unable to get interface address while rewriting DNS servers during relay of server response ");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the DHCPV6_OPT_AUTH option is set in a DHCPv6 server response, we can't rewrite the DNS server within the response as it would result in a checksum mismatch.
Instead of silently dropping the server response, forward the unmodified response instead.