Skip to content

feat: include has_binaries flag in build spec #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AbhinavPradeep wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: include has_binaries flag in build spec #1278

AbhinavPradeep wants to merge 6 commits into from

Conversation

@AbhinavPradeep
Copy link
Contributor

@AbhinavPradeep AbhinavPradeep commented Jan 13, 2026

Summary

Added a has_binaries flag to the build spec. This helps differentiate between pure and non-pure Python wheels.

Description of changes

  1. Added a has_binaries flag to the BaseBuildSpecDict.
  2. Macaron now defers from generating a dockerfile for non-pure wheels.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 13, 2026
@behnazh-w behnazh-w marked this pull request as ready for review January 13, 2026 11:18
@behnazh-w behnazh-w self-requested a review as a code owner January 13, 2026 11:18
@behnazh-w behnazh-w changed the title feat: include has_binaries flag feat: include has_binaries flag in build spec Jan 13, 2026
@behnazh-w behnazh-w changed the base branch from main to abhinav/fix-gen-build-spec-bugs January 13, 2026 11:19
behnazh-w
behnazh-w reviewed Jan 13, 2026
View reviewed changes
Copy link
Member

@behnazh-w behnazh-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an integration test for a Python package that includes binaries, to test this new field in the spec?

@behnazh-w behnazh-w changed the base branch from abhinav/fix-gen-build-spec-bugs to main January 15, 2026 11:00
behnazh-w
behnazh-w reviewed Jan 20, 2026
View reviewed changes
Copy link
Member

@behnazh-w behnazh-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now all the integration tests are testing pure Python packages. How about adding pkg:pypi/cryptography@46.0.3 as a new integration test, which releases non-pure packages?

src/macaron/slsa_analyzer/package_registry/pypi_registry.py

@contextmanager
def wheel(self) -> Generator[None]:
def wheel(self, download_binaries: bool) -> Generator[None]:
Copy link
Member

@behnazh-w behnazh-w Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the doctring to include the parameter, return type, and raised exceptions.

behnazh-w
behnazh-w reviewed Jan 20, 2026
View reviewed changes
src/macaron/build_spec_generator/common_spec/pypi_spec.py Outdated

try:
with pypi_package_json.wheel():
# Argument called download_binaries
Copy link
Member

@behnazh-w behnazh-w Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve this comment.

@AbhinavPradeep
Copy link
Contributor Author

AbhinavPradeep commented Jan 20, 2026

Right now all the integration tests are testing pure Python packages. How about adding pkg:pypi/cryptography@46.0.3 as a new integration test, which releases non-pure packages?

Actually I did add tree-sitter as an integration test, this was how I found the non-determinism bug. I believe I forgot to add it in the latest commit 😅

@AbhinavPradeep
feat: add has_binaries flag to the buildspec.
bd90b4d 
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
@AbhinavPradeep
fix: modified integration tests to reflect new feature.
fcab8a4 
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
@AbhinavPradeep
fix: modified unit tests to reflect new feature.
8f660df 
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
@AbhinavPradeep
fix: addressed PR comments and a bug that caused non-determinism in t…
cc98d04 
…he build_requires.

Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
@AbhinavPradeep
test: added new integration test for a non-pure Python package.
a4be69c 
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
@AbhinavPradeep
fix: address review comments
452c46d 
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
@AbhinavPradeep AbhinavPradeep force-pushed the abhinav/include-has-binaries-flag branch from 61d9fbe to 452c46d Compare January 21, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behnazh-w behnazh-w behnazh-w left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhinavPradeep @behnazh-w