Версия 3.7.0 с плагинами v2.0.0, тестирование на GA #340

ovcharenko-di · 2025-12-17T10:37:14Z

В этом PR:

полноценное тестирование на GA (по аналогии с gitsync-plugins)
- на двух версиях платформы 1С
- тестирование на Windows и Linux
исправление падающих тестов
отключение сборки exe и всего, что с этим связано
обновление конфигов для VS Code
исправление опечаток, удаление лишнего
удаление Jenkinsfile и конфига для Travis-CI за ненадобностью

@oscript-library/Collaborators - пожалуйста, проверьте изменения и прокомментируйте их

github-actions · 2025-12-17T11:48:28Z

	Tests	Passed ✅	Skipped	Failed
Результаты тестов. ОС: windows-latest. Версия 1С: 8.3.24.1691. Версия OneScript: 1.9.2	428 ran	428 passed	0 skipped	0 failed

View Результаты тестов. ОС: windows-latest. Версия 1С: 8.3.24.1691. Версия OneScript: 1.9.2

github-actions · 2025-12-17T11:48:31Z

	Tests	Passed ✅	Skipped	Failed
Результаты тестов. ОС: windows-latest. Версия 1С: 8.3.21.1624. Версия OneScript: 1.9.2	428 ran	428 passed	0 skipped	0 failed

View Результаты тестов. ОС: windows-latest. Версия 1С: 8.3.21.1624. Версия OneScript: 1.9.2

github-actions · 2025-12-17T11:50:16Z

	Tests	Passed ✅	Skipped	Failed
Результаты тестов. ОС: ubuntu-22.04. Версия 1С: 8.3.24.1691. Версия OneScript: 1.9.2	428 ran	428 passed	0 skipped	0 failed

View Результаты тестов. ОС: ubuntu-22.04. Версия 1С: 8.3.24.1691. Версия OneScript: 1.9.2

github-actions · 2025-12-17T11:50:28Z

	Tests	Passed ✅	Skipped	Failed
Результаты тестов. ОС: ubuntu-22.04. Версия 1С: 8.3.21.1624. Версия OneScript: 1.9.2	428 ran	428 passed	0 skipped	0 failed

View Результаты тестов. ОС: ubuntu-22.04. Версия 1С: 8.3.21.1624. Версия OneScript: 1.9.2

Copilot

Pull request overview

This PR updates gitsync to version 3.7.0 with plugins v2.0.0, introducing comprehensive GitHub Actions-based testing infrastructure while removing legacy CI/CD configurations (Travis CI and Jenkins). The changes modernize the testing approach, fix various spelling errors, and update all dependencies to newer versions.

Key Changes:

Implemented full GitHub Actions testing workflow with coverage collection and multi-platform support (Windows/Linux, multiple 1C platform versions)
Updated all package dependencies to newer versions (e.g., logos 1.7.1, v8runner 1.12.0, gitrunner 1.8.0)
Fixed numerous spelling errors throughout feature files and step definitions (e.g., "тестовой" → "тестовый", "ищю" → "ищу")
Refactored test execution to use centralized build/reports directory structure with improved coverage handling

Reviewed changes

Copilot reviewed 46 out of 47 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
travis-ci.sh	Removed legacy Travis CI build script
Jenkinsfile	Removed legacy Jenkins pipeline configuration
packagedef	Updated version to 3.7.0 and upgraded all dependency versions
build_packagedef	Updated version to 3.7.0 and environment version to 1.9.2
tasks/test.os	Major refactoring: added coverage parameter support, centralized report outputs to build/reports, improved feature execution logic
tasks/coverage.os	Added platform-specific encoding handling and reorganized coverage file structure
tasks/make.os	Commented out EXE build functionality and removed commented debug code
tasks/build.os	Removed commented-out code and debug statements
tasks/get-plugins.os	Changed repository from khorevaa to oscript-library, renamed parameters from branch to commit pointer
tasks/oscript.cfg	Changed lib.system to lib.additional for module path configuration
tests/fixtures/ext.yaml	Fixed typo: "extention" → "extension"
.vscode/tasks.json	Modernized to VS Code 2.0.0 task format with proper type, label, and presentation properties
.vscode/launch.json	Removed debugPort and protocol fields from launch configuration
.gitignore	Reorganized ignore patterns, added build/ directory
.gitattributes	Added line ending rules for cross-platform compatibility
.bsl-language-server.json	New BSL Language Server configuration file
.github/workflows/qa.yml	Changed test command from "opm run coverage" to direct oscript execution
.github/CONTRIBUTING.md	Improved formatting, updated instructions, and refreshed last update date
features/opm/opm-build.feature	Fixed typo: "установку" → "установки"
features/core/sync.core.feature	Fixed typo: "тестовой" → "тестовый", changed VERSION value from 0 to 7
features/core/sync.batch.feature	Fixed typo: "тестовой" → "тестовый", removed commented-out test code
features/core/step_definitions/sync.batch.os	Updated procedure names to match corrected spelling
features/core/step_definitions/shared.os	Fixed spelling in comments and procedure names, added new step for git author setup, removed commented code
features/core/step_definitions/check.core.os	Updated step names in list to match corrected capitalization
features/core/check.core.feature	Fixed capitalization in step names
features/cmd/v8path.feature	Fixed typo: "ищю" → "ищу", changed VERSION value from 0 to 7
features/cmd/sync.feature	Fixed typo: "тестовой" → "тестовый", changed VERSION value from 0 to 7
features/cmd/step_definitions/v8path.os	Updated procedure name to match corrected spelling
features/cmd/step_definitions/sync.core.os	Removed extra blank lines
features/cmd/step_definitions/shared.os	Fixed spelling in comments and procedure names, added new step for git author setup
features/cmd/step_definitions/init.os	Removed extra blank lines
features/cmd/step_definitions/extension.os	Added BSL diagnostic suppressions, improved comment formatting
features/cmd/step_definitions/all.os	Fixed spelling in comment and procedure name, removed unused step
features/cmd/setversion.feature	Fixed typo and whitespace, added git author setup step
features/cmd/ibconnection.feature	Fixed typo, changed VERSION value from 0 to 7, added git author setup step
features/cmd/extention.feature	Fixed typo, changed VERSION value from 0 to 4
features/cmd/clone.feature	Added git author setup step, fixed trailing whitespace
features/cmd/all.feature	Fixed spelling, improved table alignment and formatting

Comments suppressed due to low confidence (1)

travis-ci.sh:1

В CI-скрипте ранее использовалась команда наподобие curl http://oscript.io/downloads/$OSCRIPT_VERSION/deb для загрузки и установки пакета через dpkg -i, что позволяло атакующему с доступом к сети (MITM) подменить содержимое пакета и выполнить произвольный код в среде сборки. Для подобных установок необходимо использовать как минимум HTTPS-URL и, по возможности, проверку подписи или хэша загружаемого артефакта. Текущий PR удаляет этот скрипт и тем самым устраняет уязвимость; при восстановлении аналогичной логики важно использовать защищённый канал и проверку целостности.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tasks/get-plugins.os

tasks/test.os

Copilot · 2025-12-17T14:34:34Z

tasks/test.os

+ТекКаталог = ТекущийКаталог();
+КаталогФайловПокрытия = "";

-Если АргументыКоманднойСтроки.Количество() = 0 Тогда
-	ТолькоЮнитТесты = Ложь;
-Иначе
-	ТолькоЮнитТесты = Булево(АргументыКоманднойСтроки[0]);
-КонецЕсли;
+Для Каждого Элемент Из АргументыКоманднойСтроки Цикл
+	Если Элемент = "coverage" Тогда
+
+		КаталогФайловПокрытия = ОбъединитьПути(ТекущийКаталог(), ".", ИмяКаталогаФайловПокрытия);
+		ФС.ОбеспечитьПустойКаталог(КаталогФайловПокрытия);

-// Попытка
-// 	ТестыПрошли = ПрогнатьТесты();
+		Прервать;
+	КонецЕсли;
+КонецЦикла;

-// Исключение
-// 	ТестыПрошли = Ложь;
-// 	Сообщить(СтрШаблон("Тесты через 1testrunner выполнены неудачно
-// 	|%1", ПодробноеПредставлениеОшибки(ИнформацияОбОшибке())));
-// КонецПопытки;
+УстановитьТекущийКаталог(ТекКаталог);


The variable "ТекКаталог" is saved at line 244 but never used afterwards. The code sets the current directory back using "УстановитьТекущийКаталог(ТекКаталог)" at line 257, but there's no code between lines 244-257 that changes the current directory, making this operation unnecessary.

.vscode/launch.json

Copilot · 2025-12-17T14:34:35Z

features/core/step_definitions/check.core.os


 //ТестовыйПлагин реализует ИнтерфейсаПлагинов
-Процедура ТестовыйплагинРеализуетИнтерфейсаплагинов() Экспорт
+Процедура ТестовыйплагинРеализуетИнтерфейсплагинов() Экспорт


The procedure name "ТестовыйплагинРеализуетИнтерфейсплагинов" doesn't match the capitalization in the feature file which expects "ТестовыйПлагинРеализуетИнтерфейсПлагинов" (with capital letters in "Плагин" and "Плагинов"). This mismatch will cause BDD step matching to fail at runtime. The procedure name should use proper camel case: "ТестовыйПлагинРеализуетИнтерфейсПлагинов".

tasks/test.os

tasks/get-plugins.os

tasks/coverage.os

.vscode/tasks.json

features/core/step_definitions/check.core.os

nixel2007 · 2025-12-17T15:26:06Z

LGTM!

This reverts commit 36cca7e.

sonar-openbsl-ru-qa-bot · 2025-12-18T16:59:57Z

Quality Gate passed

Issues

Measures

Project ID: gitsync

View in SonarQube

ovcharenko-di force-pushed the fix/testing branch from 68117f8 to cf4fc7a Compare December 17, 2025 11:42

ovcharenko-di requested review from Copilot and nixel2007 December 17, 2025 14:27

Copilot started reviewing on behalf of ovcharenko-di December 17, 2025 14:28 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

nixel2007 approved these changes Dec 17, 2025

View reviewed changes

ovcharenko-di force-pushed the fix/testing branch from 9498f21 to 96ee667 Compare December 18, 2025 10:21

ovcharenko-di and others added 18 commits December 18, 2025 13:35

upd tests

3dd9e0c

fix testing

6e09c8a

add gitkeep

14c3312

rm install-gitsync, fix test command

78c7bf9

Revert "add gitkeep"

b9c2816

This reverts commit 36cca7e.

upd tasks and debug

35e2ac2

fix typo

7aa8121

fix typo

66d1392

speed up tests

17399af

fix typo

5fc9bc0

add bsl language config

66989ff

upd gitignore

a708b7f

rip jenkins

1ce3bcb

rip travis-ci

835211c

bump deps and version

573d827

upd guide

e3356b7

upd testing workflow

0604816

fix

ebe5ddf

Your Name added 11 commits December 18, 2025 13:35

fix steps, features and typos

d8633d4

switch to local

c3d5fee

implement test

c4d12b9

upd coverage (from gitsync-plugins)

75a95f5

cleanup

e279ea6

fix naming

60f85dd

rm exe, cleanup

6999ee6

switch to full paths, fix logging

751ec3d

take plugins from master@gitsync-plugins

777bfef

bump

593bedc

add gitattributes

14def65

ovcharenko-di force-pushed the fix/testing branch from 96ee667 to 14def65 Compare December 18, 2025 10:36

Your Name added 6 commits December 18, 2025 14:30

fix sonar issues

7eaf668

fix deps

017cb62

fix debug

692e609

fix tasks

9d151ec

upd test.os

a6df48e

fix typos

02bc83f

nixel2007 approved these changes Dec 18, 2025

View reviewed changes

rm redundant lines

8f2e785

ovcharenko-di merged commit aa3f4ee into oscript-library:develop Dec 18, 2025
10 checks passed

Версия 3.7.0 с плагинами v2.0.0, тестирование на GA #340

Версия 3.7.0 с плагинами v2.0.0, тестирование на GA #340

Conversation

ovcharenko-di commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nixel2007 commented Dec 17, 2025

Uh oh!

sonar-openbsl-ru-qa-bot bot commented Dec 18, 2025

Quality Gate passed

Issues

Measures

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 17, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading