Fix async v3 credential hydration for SSM resolution #138
+42
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored AWS provider to resolve and hydrate v2 credentials asynchronously before building v3 client config. Updated related methods to be async and added logic to handle lazy credential providers, improving compatibility with various AWS credential sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SLS_AWS_SDK_V3=1was failing${ssm:...}resolution withUnrecognizedClientExceptionbecause Serverless forced early resolution of AWS SDK v2 credentials and copied them into SDK v3. Since credentials sourced from environment variables were not valid at that point in execution, the resolved credentials were incorrect and then reused by SDK v3.await getPromise/refreshPromise(when present) in_resolveV2CredentialsForV3, so the v3 client config receives realaccessKeyId,secretAccessKeyandsessionToken. If no keys are available, we return undefined and allow SDK v3 to fall back to its own credential provider chain