bugfix: fix JSONDecodeError on instance creation by updating urls and headers. #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Summary
JSONDecodeErroris raised while creating instances of classes:MatchPlayerSummaryWhen manually opened in a web browser, the match url, json url, and new json url, all return Access Denied messages.
Reproduction
Run bug.py
Output (before fix)
Tests (before fix)
Fix Summary
Matchclass: updatedself.match_url, andself.json_urlto working endpoints.Playerclass: comment out references tonew_json_url(no known working endpoint).headersto prevent 403 errors, since updated URLs weren't sufficient to prevent errors.Output (after fix)
Tests (after fix)
Tests
New
pytesttests added intests_new.py.Addition changes
findAll(depreciated in BeautifulSoup4) tofind_all.