Skip to content

Conversation

@Seinzu
Copy link

@Seinzu Seinzu commented Jul 18, 2025

Version 2.0.2 fixes a sev:high issue.

This PR brings over the commits from version 2.0.2 of multer. The v2 branch seemed to be quite far behind so I'm just doing this straight into master.

I fixed some lint issues - they didn't seem like they'd be new and I don't know whether I should do them.

I'll test this commit hash on dev before merging.

@Seinzu Seinzu force-pushed the ar-update-multer-2.0.2 branch from cee155e to f3d6794 Compare July 18, 2025 14:50
@Seinzu Seinzu marked this pull request as ready for review July 18, 2025 14:51
@Seinzu Seinzu requested a review from mserranom July 18, 2025 14:52
@Seinzu
Copy link
Author

Seinzu commented Jul 18, 2025

@mserranom does this seem like the right approach, I don't think it's quite what you did.

@mserranom
Copy link

The v2 branch seemed to be quite far behind so I'm just doing this straight into master.

That's right, they moved v2 development to main, and I rebased in #3.

does this seem like the right approach, I don't think it's quite what you did.

Looks like you didn't rebase the same way? The changes upstream are correct, but in reverse order:

Screenshot 2025-07-21 at 09 53 29 Screenshot 2025-07-21 at 09 53 18

@Seinzu
Copy link
Author

Seinzu commented Jul 21, 2025

The way I did it was I checked out master and then rebased our changes onto upstream/main. I'll have another go at it later and see if I can get it to work a different way.

@briangough
Copy link

We're in need of the multer 2.0.2 upgrade for the next server pro release... anything I can do to help on this?

@Seinzu
Copy link
Author

Seinzu commented Jul 24, 2025

@briangough I was planning to work on this tomorrow during the backlog day. Does it need to be released before tomorrow/Monday?

The main task is setting up a way to test collabratec.

@briangough
Copy link

I think that should be fine, thanks.

@Seinzu
Copy link
Author

Seinzu commented Jul 29, 2025

Not needed since we merged the patched version of this in the main repo

@Seinzu Seinzu closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants