Extract creation of marker and polygon for waypoints to remove duplicated code for OSM map #2158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/run-tests |
|
Build & Test complete. ✨ |
Collaborator
|
Just needs a little ktfmt ( |
Contributor
Author
|
Thanks for letting me know, formatted 👍 |
Collaborator
|
/run-tests |
|
Build & Test complete. ✨ |
Collaborator
|
Hmm, ktfmt still complaining. Can you doublecheck? |
Contributor
Author
|
Not quite sure why IDE ktfmt did not catch these. Ran formatter via CLI this time which made the changes. Should be good now hopefully. |
Collaborator
|
/run-tests |
|
Build & Test complete. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract Marker and Polygon creation for OSM map to separate functions as the functions
addRegionandreDrawRegionsboth had effectively the same implementations with only a slight difference.The difference between them is
addRegionhad an additional filter so that the polygon would only be drawn if the points were valid coordinates whereas "reDrawRegions" did not have this check. This filter will now be applied in both cases.