This repository was archived by the owner on Dec 8, 2025. It is now read-only.
SES 3674 contact deletion sync #1713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bilb <1544279+Bilb@users.noreply.github.com>
Co-authored-by: mpretty-cyro <15862619+mpretty-cyro@users.noreply.github.com>
* WIP * WIP * Adjusted view_visible_message_content to show any msg w/ a document attachment above it * Cleanup * Nudge to trigger CI build * Adjusted view layout to display any text accompanying an audio file --------- Co-authored-by: alansley <aclansley@gmail.com>
* Starting to import Lucide icons and clean up * Removing unused icons * Lucide icons + removing unsued stuff Removed the whole EMoji/MediaKeyboard classes as they didn't seem used * More Lucide icons + ui tweaks + clean up * comment * Wrong tinting * delete icon * More icons * check icons
* Starting to import Lucide icons and clean up * Removing unused icons * Lucide icons + removing unsued stuff Removed the whole EMoji/MediaKeyboard classes as they didn't seem used * More Lucide icons + ui tweaks + clean up * comment * Wrong tinting * delete icon * More icons * check icons * edit icon (ic_pencil) * edit icon * Search icon (ic_search) * settings icons (ic_settings) * back icon (ic_chevron_left) * icon forward arrow (ic_chevron_right) * icon circle dots (ic_circle_dots_custom) * icon read (ic_eye) * icon disappearing messages (ic_clock_x) * refresh icon (ic_refresh_cw) * globe icon * message icon (ic_message_square) * icon message request (ic_message_square_warning) * group and invite icons (ic_users_group_custom, ic_user_round_plus)) * icons: lock, unlock, audio/notification (ic_lock_keyhole, ic_lock_keyhole_open, ic_volume_2, ic_volume_off ) * icon mute / mic off (ic_mic_off) * icon appearance, recovery (ic_paintbrush_vertical, ic_recovery_password_custom) * icons: help, help circle, qr code * icon block/ban
#846) * Set the recovery phrase as being viewed when the user has visited the RecoveryPasswordActivity * Fix scenario whereby permanently hiding the recovery phrase via the banner does not --------- Co-authored-by: alansley <aclansley@gmail.com>
* Starting to import Lucide icons and clean up * Removing unused icons * Lucide icons + removing unsued stuff Removed the whole EMoji/MediaKeyboard classes as they didn't seem used * More Lucide icons + ui tweaks + clean up * comment * Wrong tinting * delete icon * More icons * check icons * edit icon (ic_pencil) * edit icon * Search icon (ic_search) * settings icons (ic_settings) * back icon (ic_chevron_left) * icon forward arrow (ic_chevron_right) * icon circle dots (ic_circle_dots_custom) * icon read (ic_eye) * icon disappearing messages (ic_clock_x) * refresh icon (ic_refresh_cw) * globe icon * message icon (ic_message_square) * icon message request (ic_message_square_warning) * group and invite icons (ic_users_group_custom, ic_user_round_plus)) * icons: lock, unlock, audio/notification (ic_lock_keyhole, ic_lock_keyhole_open, ic_volume_2, ic_volume_off ) * icon mute / mic off (ic_mic_off) * icon appearance, recovery (ic_paintbrush_vertical, ic_recovery_password_custom) * icons: help, help circle, qr code * icon block/ban * close icon (ic_x) * pin/unpin icons * switch camera icon (ic_switch_camera) * warning icon (ic_triangle_alert) * phone icons * share icon + clean up unused files * mark as read icon + clean up * default video placeholder + clean up Removed the caption icon from the media rail Cleaned up logic for thumbnail error and placeholder * Clean up
* info icon (ic_info) * icon video off (ic_video_off) * emoji fallback icon (ic_square_x) * expand icon (ic_maximize_e) * default profile icon and video swap icon * missed call icon * chevron up and down * icons for image edit screen and emoji stickers * Giphy screen icons + reworked search bar * removed unused icons
* Added progress indicator for group editing * Max size on AndroidView and remove background, add semantics * More update * Reuse LoadingDialog * Comment
# Conflicts: # app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageView.kt # app/src/main/java/org/thoughtcrime/securesms/groups/compose/EditGroupScreen.kt
Merge latest changes to groups back to dev
* Fix crash when admin deletes an attachment * Fix wrong column used in query
* Initial commit * Initial attempt at modernising PhassphrasePromptActivity and BiometricSecretProvider * Commit before refactoring to cache shared content Uri * External sharing with fingerprint-locked device now working * Adjust PassphrasePromptActivity to not allow multiple instances if you have one then external share via session * Cleanup and documentation * End of day push * Yeah, now external sharing ONLY works on a Pixel 7a and not most other things - will need to rework this in 2025 =/ * Added forced READ_URI permission to intent - works for external share of links now, but not images at present * WIP * Working, now to clean up * Broke then fixed * End of day push * Now working on Pixel 7a also * Commit before refactor * Refactor WIP * Refactored PassphraseRequiredActionBarActivity to ScreenLockActionBarActivity, amongst other things * Cleanup * Tiny fix * Further cleanup * WIP filename fix * Fixed GIF saving amongst other things * Cleanup for PR * Fixed overlooked drawable ID change * Cleanup * PR feedback * PR feedback * PR feedback * PR feedback * PR feedback * Fix startup crash & successful unlock drawable * Adjusted fileprovider back to previous name to keep inline with avatar and share logs file providers * Cleaned up ShareActivity null-checks via lateinits * Fixed up ScreenLockActivity so we don't get stuck & inform user of system-level biometric lockouts * Fixed ShareActivity.onCreate to match OG behaviour * Added filename handling for video files * All working - commit before cleanup * Cleaned up * Addressed PR feedback regarding biometric unlock * Re-fixed external share filenames following Media class adjustment today * Cleanup * Fixed Giphy GIF filenames * PR cleanup * PR feedback * Added comment * Reverted onBackPressedDispatcher change * Added voice message filename generation method to FilenameUtils * Push before refactor * WIP * Streamline filename creation * Cleanup * Enforce non-null status on extracted filename * Adjusted Attachments to force filenames & removed reliance on Uri filename extraction * End of day push * Added synthesized filename creation for pre-existing voice messages that lack a filename * Cleanup and refactor mechanism for legacy voice message filename synthesis * Remove unnecessary call to getFilenameFromUri if we can extract the filename from the attachment * Added filename synthesis on input from legacy Session Android clients that provide null filenames * Added some additional mime-types to our incoming 'fromProto' filename generation - should be very comprehensive now * Leaving logic on the app side Removed logic from libsession Sanitising file names before saving them to storage Made sure we don't displa a date when getting filename from Slide otherwise it'll keep changing * Cleaned up * Using the URI's timestamp when possible --------- Co-authored-by: alansley <aclansley@gmail.com> Co-authored-by: ThomasSession <thomas.r@getsession.org>
Bring 1.21.3 to dev
* Making sure the path activity renders well o n small screens * Tweaked the function * Removed commented code
* Adding an expired state for image attachments * UI updates Pending/Expired attachments now use different icons for different types Consistent padding and styling for bubbled control messages (call cm, deleted message, pending/expired attachments) * Fixing pending/expired view styling * Catering for expired 404 attachments * Removing the duplication of attachment state. Relying only on the enum * Handling video icon for attachment control * Renamed Pending view to AttachmentControl as it will have more responsibility now Handling loading and failed state in attachment controls * Properly handling quotes for attachment types and states * Quote styling fixes * Message UI tweaking * Retry on tap for failed attachments * Retrying failed attachments * Renamind pending attachment download * Removing redundant state in attachment controls * Catering for multi image attachment control and calculating total attachment size * Making sure retry works for multiple attachments * Showing attachment controls in the message details instead of the carousel if the image isn't downloaded * Making sure we show videos in the message details page * Fixing audio slide issue * Making sure we can interact with pending and failed attachments from the message details * Message details show state update when downloading a pending attachment Also added a new debug menu item to "untrust" attachments * crowdin strings * Added a todo * PR feedback
* Android target sdk 15 Removed unused libraries Fixed broken icon colors * Bumping libsession-util
Release/1.22.0
Release/1.22.0
* SES-3589 - qa tags * Catering for insets in android 15 * Fixing scrim colour * Adding back loader on images as it is useful for outgoing messages * Catering for keyboard insets due to new target sdk 35 * Using latest webrtc lib * Catering for insets when calculating recyclerview scroll * Enabling predictive back gesture for android 15 devices * Reworking new message fragment for ime handling on all versions including small screens * Removing insets from base app bar as theyare handled by the base activity
paprently older versions of android can't use gradients with a mix of hex colors and dynamic theme attributes
Release/1.22.1
* Window insets in app bars * Fixing broken draw for inputbar buttons (visible in light themes) * Fixing qa tag for legacy group recreation * SES-3597 - doc attachment corners * Fixing FAB animation * Extracting quotes and audio out of the message bubble. Ability to send text with documents (with no confirmation yet!) * SES-3603 Making sure quotes use underlying original text * Making sure we still render text when suppressing thumbnail * Reverting for now until we find a solution for confirming documents before sending * Cleaning up ui * Making sure items respect their bg shape
* WIP * WIP * Block and delete functionality now working * Tidy up * Log a warning if we fail to delete a recipient * Remove unneccessary bool return to menu item click listener * Commit what I have before we move the block / delete over to a bottom sheet * Fix contact deletion to fully reset + some PR feedback * Tweaks for latest dev * Import clean up * Fixing code * Fixes * Clean up * naming * Config handling * Proper code for deleting a contact * Tweaked compose sheets * Proper set up for block and delete contact in bottom sheet fragment Using coroutine properly * Showing confirmation * Clean up * Removed toast * Adding Config * Filtering out blocked contacts * filtering messages from blocked contacts * Filtering out blocked contacts inseaarch * Update app/src/main/java/org/thoughtcrime/securesms/contacts/SelectContactsToInviteToGroupActivity.kt Co-authored-by: SessionHero01 <180888785+SessionHero01@users.noreply.github.com> * Update app/src/main/java/org/thoughtcrime/securesms/home/HomeViewModel.kt Co-authored-by: SessionHero01 <180888785+SessionHero01@users.noreply.github.com> * PR feedback * Only send the approval message if user wasn't already approved * Config already changed in the setRecipientXXX calls --------- Co-authored-by: alansley <aclansley@gmail.com> Co-authored-by: ThomasSession <thomas.r@getsession.org> Co-authored-by: SessionHero01 <180888785+SessionHero01@users.noreply.github.com>
* Catch config push exceptions * Tidied up
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the recipient db instead of contact to sync contact deletion