[DO NOT MERGE, WIP] feat: ray-less SFT #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'm just wondering whether we should wait for upstream lora support (for the default codepath + RL), or not. For some reason the seem to be constantly reverting their lora implementation lol |
Author
|
I don't think they found a 'proper' solution for lora-based RL with sglang yet as the current proposal still unloads and reloads the lora adapter from disk (surely we can do better than that). |
Author
|
Question is whether we should:
|
* feat: support lora in ray-less SFT codepath * chore: add assert * chore: fail fast if no lora-compatible modules found * fix: set default lora dropout to 0 * fix: skip dataloader checkpoint loading if non-existent * chore: change lora defaults * feat: checkpoint in run script * feat: separate load and save paths * fix: only store trainable params in optimizer * fix: only load adapter weights on lora restore * feat: support lora in the ray-full SFT codepath (+assert that grad check. is off)
emergenz
force-pushed
the
rayless-sft
branch
from
74f4820 to
e15e2a3
Compare
Author
|
Merging now that we have a working workflow to keep in sync with upstream. |
Author
|
Actually, let's first merge #10 into this branch and then merge the entire thing into main. That way, we frontload most of the conflict resolution down the line when lora is finally merged into upstream main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.