Implementazione nuova API di anonimizzazione indirizzo #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefano-rughetti-nttdata
force-pushed
the
feature/PN-17831
branch
from
1b1eeed to
603a338
Compare
stefano-rughetti-nttdata
force-pushed
the
feature/PN-17831
branch
from
603a338 to
694b5ae
Compare
|
vincenzo-racca-pa
requested changes
Jan 2, 2026
| private String pr; | ||
| @ToString.Exclude @Getter(onMethod=@__({@DynamoDbAttribute(COL_COUNTRY)})) | ||
| private String country; | ||
| @ToString.Exclude @Getter(onMethod=@__({@DynamoDbAttribute(COL_ATTEMPT)})) |
Contributor
There was a problem hiding this comment.
@stefano-rughetti-nttdata Il @ToString.Exclude è inutile nei nuovi campi.
Inoltre eliminerei il ToString.Exclude anche per pr, city, city2, country
| ) | ||
| .map(response -> { | ||
| log.debug("{} paperRequestId:{} paperAddressId:{}", EXIT_LOG, response.getPaperRequestId(), response.getAddressId()); | ||
| return ResponseEntity.ok(ControllerMapper.createPaperAddressResponse(response)); |
Contributor
There was a problem hiding this comment.
@stefano-rughetti-nttdata più giusto che il mapping lo faccia il service.
| public class ControllerMapper { | ||
| public static PaperAddressResponse createPaperAddressResponse(PaperAddressEntity entity) { | ||
| return new PaperAddressResponse() | ||
| .paperAddressId(entity.getAddressId()); |
Contributor
There was a problem hiding this comment.
@stefano-rughetti-nttdata eliminerei questa classe e farei restituire al service direttamente l'Id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.