Use post-processing approach for test report formatting to support Gradle 9 #891
+172
−255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
|
||
| class TestReportFormattingPluginIntegrationSpec extends IntegrationSpec { | ||
| private static final List<String> GRADLE_VERSIONS = ["7.6.4", "8.8", GradleVersion.current().getVersion()] | ||
| private static final List<String> GRADLE_VERSIONS = ["8.8", GradleVersion.current().getVersion(), "9.3.0"] |
There was a problem hiding this comment.
this will disappear when the migration happens. We shoudl probably add a note to the excavator to be like if it is sees this, it should add to the test-versions.yml file
| new LogParser<>(TestLogFilter.INSTANCE.combineWith(LogFormatter.INSTANCE, (include, formatted) -> | ||
| include ? Optional.of(formatted) : Optional.empty())); | ||
|
|
||
| private static final Pattern PRE_PATTERN = Pattern.compile("(<pre[^>]*>)(.*?)(</pre>)", Pattern.DOTALL); |
There was a problem hiding this comment.
I would want you to find the stdout/stderr section, this feels like too big a capture group.
Contributor
Author
There was a problem hiding this comment.
updated to Match <pre> tags within stdout/stderr sections: <h2>standard output</h2>...<pre>...</pre>
If we think this is a sensible route to go I'll tidy up and migrate the tests etc
FinlayRJW
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The
TestReportFormattingPluginrelied on internal Gradle APIs (HtmlTestReport,TestReporter, etc.) using reflection to intercept and format test report output. This approach broke frequently across Gradle versions, requiring version-specific reflection hacks for 8.8, 8.11, and now completelybreaking in 9.3.0 where
org/gradle/api/internal/tasks/testing/report/HtmlTestReportwas removed entirely.After this PR
Replaces the reflection-heavy internal API approach with a simple post-processing strategy. The plugin now uses
FlowScope.always()to run after test tasks complete, walking the generated HTML report directory and reformatting witchcraft log JSON lines in-place. This approach works across all Gradle 8.1+versions including 9.x without version-specific code
==COMMIT_MSG==
Use post-processing approach for test report formatting to support Gradle 9
==COMMIT_MSG==
Possible downsides?
Drops Gradle 7 support. The post-processing happens after test execution completes rather than during report generation, but the end result is equivalent.