Migrate WitchcraftLoggingPluginTest to java framework
#892
+55
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grationSpec` to the new Java Junit framework
Generate changelog in
|
FinlayRJW
changed the base branch from
develop
to
roomba/migrate-gradle-testing-junit-framework-95bbab190963ce4c
FinlayRJW
changed the base branch from
roomba/migrate-gradle-testing-junit-framework-95bbab190963ce4c
to
develop
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 🔄 Changelog entries were re-generated at Fri, 23 Jan 2026 16:33:30 UTC!📋Changelog Preview💡 Improvements
|
versions.props
Outdated
| @@ -1,6 +1,5 @@ | |||
| com.fasterxml.jackson.*:* = 2.20.1 | |||
| com.fasterxml.jackson.core:jackson-annotations = 2.20 | |||
| com.palantir.gradle.plugintesting:gradle-plugin-testing-junit = 0.50.0 | |||
There was a problem hiding this comment.
you won't have to do this anymore hopefully once palantir/gradle-plugin-testing#353 merges
Comment on lines
71
to
73
| .add("java") | ||
| .add("java-library") | ||
| .add("com.palantir.witchcraft-logging-testreport"); |
There was a problem hiding this comment.
same, this should be addressed with palantir/gradle-plugin-testing#353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
WitchcraftLoggingPluginTestwas a groovy test usingSpecificationAfter this PR
Now we use
GradlePluginTestsand make it a java test==COMMIT_MSG==
Migrate
WitchcraftLoggingPluginTestto java framework==COMMIT_MSG==
Possible downsides?
dont have access to the
projectlike inSpecificationso have to be a bit creative to check if a plugin is present