Skip to content

Fix race condition in analytics increment #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gul-ahmad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix race condition in analytics increment #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/Adapters/Laravel/Repositories/DatabaseAnalyticsRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,23 @@ public function increment(string $name, EventType $event): void
return;
}

if (DB::table('pan_analytics')->where('name', $name)->count() === 0) {
if (DB::table('pan_analytics')->count() < $maxAnalytics) {
DB::table('pan_analytics')->insert(['name' => $name, $event->column() => 1]);
}
DB::transaction(function () use ($name, $event, $maxAnalytics) {
// Lock the table for this name to prevent race conditions
$existing = DB::table('pan_analytics')
->where('name', $name)
->lockForUpdate()
->first();

return;
}
if ($existing === null) {
// Check total count with lock to prevent race condition on max analytics
if (DB::table('pan_analytics')->lockForUpdate()->count() < $maxAnalytics) {
DB::table('pan_analytics')->insert(['name' => $name, $event->column() => 1]);
}
return;
}

DB::table('pan_analytics')->where('name', $name)->increment($event->column());
});
}

/**
Expand Down