Skip to content

Conversation

@nsaechao
Copy link
Contributor

@nsaechao nsaechao commented Jun 6, 2018

Summary:

  • Remove building for Mac versions < 10.8.
  • Fix a bug in the build-node.sh script where the default version was incorrectly set with a '-' character.

Tested:

./build-node.sh & ./build-yarnpkg.sh

@nsaechao
Copy link
Contributor Author

nsaechao commented Jun 6, 2018

Based on the new format for merging and then uploading binaries, what is the process if there are no script changes required to add a new binary?

@stuhood
Copy link
Member

stuhood commented Jun 7, 2018

Based on the new format for merging and then uploading binaries, what is the process if there are no script changes required to add a new binary?

The new process would be to copy the edited script into the locations where the binaries should be fetched, and then create symlinks to the other locations where the binary should be used.

See #66 for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants