Add global coordinates broker but keep global cursor transform #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtaala
reviewed
Mar 7, 2024
This approach calls Utils.getPointerCoords() (the unified touch broker) when the event starts ONLY. Since the touch tracker fails to update once the event is "adopted" by a widget, we still need to update the global cursor's coordinates. This superficially fixes #764, but REVERT this commit before working on cleaning up touch handling!
Thesola10
force-pushed
the
global-touch-coords2
branch
from
5ca1d4f to
fbca41f
Compare
Thesola10
changed the title
Collaborator
|
@Thesola10 let me know if you when you want me to test/review this one. |
Collaborator
Author
|
@jtaala go ahead! |
jtaala
approved these changes
Mar 9, 2024
Collaborator
jtaala
left a comment
jtaala
left a comment
There was a problem hiding this comment.
Looks good. I switched to PaperWM's signal approach (for consistency and it's also easier to destroy/cleanup - for when/if we add more signals to utils.js.
Give it a final test and I'll merge and do a new release.
Thesola10
commented
Mar 9, 2024
Collaborator
Author
|
just filed a commit instead |
jtaala
approved these changes
Mar 9, 2024
Collaborator
jtaala
left a comment
jtaala
left a comment
There was a problem hiding this comment.
Looks good, merge when ready.
This comment was marked as resolved.
This comment was marked as resolved.
Thesola10
force-pushed
the
global-touch-coords2
branch
from
cb8dfbb to
e05a16a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR functionally fixes #764 but is non-ideal from a code quality standpoint. The cleaner version and discussion around it is and should remain in #766, this PR is a hotfix.