fix: no-std derive start fn #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Feb 20, 2025
Contributor
There was a problem hiding this comment.
This makefile doesn't seem to be used? Can we remove it?
niklasad1
reviewed
Feb 20, 2025
| 0 | ||
|
|
||
| use core::arch::asm; | ||
| unsafe { |
Contributor
There was a problem hiding this comment.
Can you add a comment that this inline assembly makes a syscall exit(0)?
niklasad1
approved these changes
Feb 20, 2025
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
Lovely, thanks for fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219 by switching to the manual
_startfunction. It is required to compile the binary targeting a none-linux triple to avoid having it codegen the original_startfunction, which then requires__libc_start_main.