Add missing standard derives to core types #2139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you! However, quite a big refactoring of the Subxt codebase is currently underway and so I think it would be best to hold off on this sort of PR until we are into the new year and have something more concrete there to build on :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing standard derives (
Hash,Eq,Copy,Default) to core data structures, includingAccountId32,RuntimeVersion, and various transaction extensions.Key Benefits:
AccountIdandRuntimeVersioncan now be used as keys inHashMapand `HashSet.Copyto small POD types (e.g.,AccountId32), reducing the need for explicit.clone()calls.