Skip to content

Conversation

@mischnic
Copy link
Contributor

@mischnic mischnic commented Jul 28, 2018

Currently investigating why the IP of Linux Node 6 Travis job wasn't whitelisted...: https://twitter.com/mischnic/status/1023151733177024514

@parro-it
Copy link
Owner

parro-it commented Sep 6, 2018

Why the failed tests should be linked to the IP of the Travis machine?
(maybe we already discussed this matter, but after some months I can't remember)

@mischnic
Copy link
Contributor Author

Why the failed tests should be linked to the IP of the Travis machine?

I guess I was a bit paranoid and only allowed pushing test results from AppVeyor and Travis servers. I've disabled that now.

@mischnic
Copy link
Contributor Author

mischnic commented Dec 10, 2018

Are you still interested in this? In the next few days, I can update this to use the newest version (pick which of 1./2. you want):

  1. screenshot-tester uses a custom cli binary on macOS, making ci builds faster because the python libraries aren't needed anymore
  2. I run screenshot-tester-server on my own server now, so no bandwidth/memory limits anymore.
  3. I could add support to push commit data to the server as well, removing the need for now. This also makes an overview over the different platforms for specific commit possible: example - styling/display of build status not yet implemented.

@parro-it
Copy link
Owner

Are you still interested in this?

Definitely yes! Do you think we can merge it now or do you prefer to implement the other improvements?

  1. and 2. are also useful additions.

@mischnic
Copy link
Contributor Author

mischnic commented Dec 10, 2018

Do you think we can merge it now or do you prefer to implement the other improvements?

I need to change the package version and the same lines in test.js, so implementing the other features would make sense. (I also don't really know if the protocol between the client&server changed slightly)

@parro-it
Copy link
Owner

Okj, let me know when it's ready!

@mischnic
Copy link
Contributor Author

mischnic commented Dec 15, 2018

screenshot-tester report

(The D link in the rightmost column opens a diff)

Windows

Windows 10 - Node 6 Windows 10 - Node 8 Windows 10 - Node 10

Windows 10 - Node 6

Overview

Failed tests:

Reference Result
D
D
D
D

Windows 10 - Node 8

Overview

Failed tests:

Reference Result
D
D
D
D

Windows 10 - Node 10

Overview

All tests passed!

Passed tests
Reference Result
D
D
D
D
D
D
D
D

macOS

macOS - Node 6 macOS - Node 8 macOS - Node 10 macOS - Node 11

macOS - Node 6

Overview

Failed tests:

Reference Result
D

macOS - Node 8

Overview

Failed tests:

Reference Result
D

macOS - Node 10

Overview

Failed tests:

Reference Result
D
Passed tests
Reference Result
D
D
D
D
D
D
D

macOS - Node 11

Overview

Failed tests:

Reference Result
D
D
Passed tests
Reference Result
D
D
D
D
D
D

Linux

Linux - Node 6 Linux - Node 8 Linux - Node 10 Linux - Node 11

Linux - Node 6

Overview

Failed tests:

Reference Result
D
D

Linux - Node 8

Overview

All tests passed!

Linux - Node 10

Overview

All tests passed!

Passed tests
Reference Result
D
D
D
D
D
D
D
D

Linux - Node 11

Overview

All tests passed!

Passed tests
Reference Result
D
D
D
D
D
D
D
D

This comment was created automatically by screenshot-tester-server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants