-
Notifications
You must be signed in to change notification settings - Fork 5
Use screenshot-tester-server for PRs #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Why the failed tests should be linked to the IP of the Travis machine? |
I guess I was a bit paranoid and only allowed pushing test results from AppVeyor and Travis servers. I've disabled that now. |
|
Are you still interested in this? In the next few days, I can update this to use the newest version (pick which of 1./2. you want):
|
Definitely yes! Do you think we can merge it now or do you prefer to implement the other improvements?
|
I need to change the package version and the same lines in test.js, so implementing the other features would make sense. (I also don't really know if the protocol between the client&server changed slightly) |
|
Okj, let me know when it's ready! |
screenshot-tester report(The D link in the rightmost column opens a diff) Windows
Windows 10 - Node 6Failed tests:
Windows 10 - Node 8Failed tests:
Windows 10 - Node 10All tests passed! macOS
macOS - Node 6Failed tests:
macOS - Node 8Failed tests:
macOS - Node 10Failed tests:
macOS - Node 11Failed tests:
Linux
Linux - Node 6Failed tests:
Linux - Node 8All tests passed! Linux - Node 10All tests passed! Linux - Node 11All tests passed! This comment was created automatically by screenshot-tester-server. |








































































































Currently investigating why the IP of Linux Node 6 Travis job wasn't whitelisted...: https://twitter.com/mischnic/status/1023151733177024514