getters setters and other enhancement to typescript definitions

[parro-it]

• I add tslint package to lint typescript defs file.
• Changed syntax for nested enums from static property to namespace to fix TS error.
• Manually add getter setters (as @mischnic said, mapped properties cannot be used for this)

While doing these changes, I also find some error in type of properties that I'm going to fix with further commits here.

[mischnic]

Unfortunately, clang-format doesn't really work well with typescript

[mischnic]

This is the last remaining "private/internal" constructor that should be removed from the public API definition

[parro-it]

Why you said constructor? Anyway, I never exactly understand how that could be used, apart for read. Do you never try to set toplevel=false on a toplevel control?

[mischnic]

No 😄 , I meant this part:

libui-napi/libui-napi.d.ts

Lines 354 to 357 in dade525

	/**
	* Create a new UiControl object.
	*/
	constructor(handle: any);

[parro-it]

Ah, sure! I guess it should be protected?

[mischnic]

I would just remove it, because libui-napi (js/*.js) itself isn't typechecked. This is just the public API.

[mischnic]

And toplevel is just a getter, so it should be readonly: (the documentation is wrong as well)

libui-napi/js/ui-control.js

Lines 36 to 42 in 5e32314

	/**
	* Set or return whether the control is a top level one.
	* @return {boolean}
	*/
	get toplevel() {
	return ControlBase.toplevel(this.handle);
	}

[parro-it]

That explains my previous doubt on its being writable 😊