-
Notifications
You must be signed in to change notification settings - Fork 5
Tables #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
parro-it
wants to merge
40
commits into
master
Choose a base branch
from
tables
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Also, libui take ownership of every uiTableValue that gots feed to a uiTable: So, we should track if a uiTableValue is fed to a uiTable, and if it is, we should avoid calling uiFreeTableValue when it get garbage collected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API for tables are completed. I wrote this PR so we can review the code and keep track of further refinements.
(1) we must increase reference count of model instances when they are attached to a table, and decrement it when they get detached, or the table get destroyed.
(2) we must increase reference count of UiImage instances every time they are returned by a js cell getter, but when can we decrement it? @andlabs said we can safely do it after next UI events are completely executed, but I guess only if the particular UI event that cause libui to redraw the table is received. So how can we detect this? Have we to check for different events types on each platform?