Update to .NET 10 and upgrade dependencies #140
Conversation
|
I'll need this project to implement records in order to be able to make use of it. I've started but am currently stuck, if you could tackle that I feel like I can help with some of the more minor new Java features! |
There was a problem hiding this comment.
Pull request overview
This pull request attempts to update the project from .NET 8.0 to .NET 10.0 and upgrade various dependencies. The changes include updating the target framework across all projects, upgrading NuGet packages (Avalonia, System.CommandLine, Microsoft.CodeAnalysis, IKVM, xUnit, and others), refactoring System.CommandLine API usage to match version 2.0.0, and updating Avalonia theme configuration to use Semi.Avalonia components.
Key changes:
- Target framework updated from
net8.0tonet10.0across all 4 projects - System.CommandLine upgraded from beta to stable 2.0.0 with corresponding API refactoring
- Avalonia packages upgraded from 11.0.x to 11.3.x with theme configuration changes
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| JavaToCSharpGui/JavaToCSharpGui.csproj | Updated target framework to net10.0 and upgraded Avalonia, CodeAnalysis, and related UI packages |
| JavaToCSharpGui/App.axaml | Updated theme configuration to use Semi.Avalonia components instead of StyleInclude |
| JavaToCSharpCli/Program.cs | Refactored System.CommandLine API calls to match version 2.0.0 stable release |
| JavaToCSharpCli/JavaToCSharpCli.csproj | Updated target framework to net10.0 and upgraded logging and command line packages |
| JavaToCSharp/JavaToCSharp.csproj | Updated target framework to net10.0 and upgraded IKVM, CodeAnalysis, ConfigurationManager, and YamlDotNet |
| JavaToCSharp.Tests/JavaToCSharp.Tests.csproj | Updated target framework to net10.0 and upgraded test framework packages (xUnit, test SDK, coverlet) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JavaToCSharpCli/Program.cs
Outdated
| private static readonly Option<bool> _includeNamespaceOption = new("--include-namespace") { | ||
| Description = "Include namespace in output", | ||
| DefaultValueFactory = _ => true | ||
| }; |
There was a problem hiding this comment.
Inconsistent trailing comma: this object initializer is missing a trailing comma after the last property, while other similar initializers (e.g., lines 16-19) include one. Maintain consistency throughout the code.
paulirwin
left a comment
paulirwin
left a comment
There was a problem hiding this comment.
Thanks for the PR. The build is failing due to needing .NET 10 SDK installed. Can you update the GitHub workflow files too? Thanks!
paulirwin
force-pushed
the
feature/dotnet10
branch
from
e98dc08 to
63e12af
Compare
2 participants
As said in the title, all tests are passing.
Fixes #138