Add program to calculate factorial in Python #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-kalra
requested changes
Oct 11, 2018
Contributor
sagar-kalra
left a comment
sagar-kalra
left a comment
There was a problem hiding this comment.
What is the significance of 2nd commit?
divyam3897
requested changes
Oct 14, 2018
programs/factorial.py
Outdated
| else: | ||
| for i in range(1,num + 1): | ||
| factorial = factorial*i | ||
| print("The factorial of",num,"is",factorial) |
programs/factorial.py
Outdated
| # Python program to find the factorial of a number provided by the user. | ||
|
|
||
| # change the value for a different result | ||
| num = 7 |
solves issue#41.
Contributor
Author
|
kindly review it now. |
divyam3897
requested changes
Oct 24, 2018
Contributor
divyam3897
left a comment
divyam3897
left a comment
There was a problem hiding this comment.
Program is to be added in language folder not programs/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #41