Skip to content

feat: add Tencent COS support #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidz-zzz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add Tencent COS support #809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bef0c6f
add tencent COS endpoint check
May 28, 2025
c1014fe
Merge branch 'master' into adhoc/fix-on-tencent-cos-support
davidz-zzz Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion storage/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ const (
// Google Cloud Storage endpoint
gcsEndpoint = "storage.googleapis.com"

// Tencent Cloud COS endpoint
cosEndpoint = ".myqcloud.com"

// the key of the object metadata which is used to handle retry decision on NoSuchUpload error
metadataKeyRetryID = "s5cmd-upload-retry-id"
)
Expand Down Expand Up @@ -1422,11 +1425,15 @@ func IsGoogleEndpoint(endpoint urlpkg.URL) bool {
return endpoint.Hostname() == gcsEndpoint
}

func IsTencentEndpoint(endpoint urlpkg.URL) bool {
return strings.HasSuffix(endpoint.Hostname(), cosEndpoint)
}

// isVirtualHostStyle reports whether the given endpoint supports S3 virtual
// host style bucket name resolving. If a custom S3 API compatible endpoint is
// given, resolve the bucketname from the URL path.
func isVirtualHostStyle(endpoint urlpkg.URL) bool {
return endpoint == sentinelURL || supportsTransferAcceleration(endpoint) || IsGoogleEndpoint(endpoint)
return endpoint == sentinelURL || supportsTransferAcceleration(endpoint) || IsGoogleEndpoint(endpoint) || IsTencentEndpoint(endpoint)
}

func errHasCode(err error, code string) bool {
Expand Down
Loading