Update for PHP 8 compatibility #8
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating an old project using pear-Auth to work with modern PHP, and these were the changes I needed to make to get things working. In summary:
__construct$storage_driverand$storage_optionsproperties on the Auth class so they aren't dynamic properties.get_magic_quotes_gpcAuth_Container_LDAP.fetchDatamethod signature$this->sessionand$_SESSION[$this->_sessionName]get out of syncFor the last one, it seems that calling
session_regenerate_idnow causes$_SESSIONto point at a new array, leaving the$this->sessionreference pointing into the old array. This was enough to get things working, but there may be a better fix.