Skip to content

Fixes misalignment of annotations #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NiklasKappel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes misalignment of annotations #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions model/render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,16 @@ def _render_rm_file(rm_file_name, page_layout=None, page_file=None):

# No valid color found... automatic fallback to default

# Sanitize page layout.
# Badly behaved PDF pages can have layouts [x_start, y_start, x_end, y_end]
# with x_start != 0 or y_start != 0.
# The reMarkable seems to compensate for this when displaying the PDF,
# but does not seem to adjust annotation coordinates.
page_layout.x_end -= page_layout.x_start
page_layout.y_end -= page_layout.y_start
page_layout.x_start = 0
page_layout.y_start = 0

# Iterate through layers on the page (There is at least one) to collect annotation data to render
layer_data_list = []
all_x = [page_layout.x_start, page_layout.x_end]
Expand Down